🐛 Fix client and env info normalization #588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Robdel12
approved these changes
Oct 19, 2021
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is this?
SDKs send client and environment information for debugging purposes. Since our SDKs span across languages and frameworks, config and snapshot options are accepted in many formats (camelCase, kebab-case, or snake_case). With recent changes however, client and environment information were extracted from snapshot options before normalization can occur. This results in snapshot validation claiming invalid options and pruning them, which then also results in a warning about missing client/env info (see linked issue). This PR amends the offending lines and extracts client/env info after normalization.
Fixes #581